[libcxx-commits] [PATCH] D106205: [libcxx][ranges] Add `counted_iterator`.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 7 inline comments as done.
zoecarver added inline comments.


================
Comment at: libcxx/include/__iterator/counted_iterator.h:227
+  _LIBCPP_HIDE_FROM_ABI
+  constexpr decltype(auto) operator[](iter_difference_t<_Iter> __n) const
+    requires random_access_iterator<_Iter>
----------------
ldionne wrote:
> Suggestion: Move this right after `operator->` to match the order it's in the spec.
I went back and forth on this a lot. Ultimately I think it's better to have it in line with the synopsis because I think that's what people will reference more. However, I could easily be swayed to move it. 


================
Comment at: libcxx/include/__iterator/counted_iterator.h:39
+template<class>
+struct __counted_iterator_concept {};
+
----------------
Mordante wrote:
> Please add `_LIBCPP_TEMPLATE_VIS` here and other structs.
AFAIU this macro doesn't actually do anything useful, so I'm not going to be applying it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106205/new/

https://reviews.llvm.org/D106205