[libcxx-commits] [PATCH] D106124: [libcxx][modules] protects users from relying on ranges detail headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Overall LGTM, but I'd like to see this again before it's shipped. I'll request changes so it shows up correctly in the review queue, and I'll look again once the Clang patch has landed.

As it's been discussed, I think we'll want a solution to avoid having to generate N files every time we add a private header. We could look into `.sh.cpp` tests. But that's non-blocking.



================
Comment at: libcxx/utils/generate_private_header_tests.py:93
+     special-cased.
+  """
+
----------------
Weird indentation?


================
Comment at: libcxx/utils/generate_private_header_tests.py:101
+    header_map = {
+        'bit_reference':     "either '<bitset>' or '<vector>'",
+        'bits':              "one of {'<algorithm>', '<bit>', '<bitset>', '<numeric>', '<random>', '<unordered_map>', '<unordered_set>', '<vector>'}",
----------------
Why are those not prefixed by their `__`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106124/new/

https://reviews.llvm.org/D106124