[libcxx-commits] [PATCH] D103960: [libc++] Towards a simpler extern template story in libc++

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai accepted this revision.
smeenai added a comment.

In D103960#2808574 <https://reviews.llvm.org/D103960#2808574>, @ldionne wrote:

> @smeenai What do you think about this (since you added the knob in the first place)? Do you agree with my assessment that the goal of avoiding a dependency on the library isn't met by `_LIBCPP_EXTERN_TEMPLATE` alone?

Sorry, this got buried in my inbox!

This looks like a great simplification to me. The work that originally needed this knob is defunct, and we were actually bitten by it in another place (something with the iostream static initializers got messed up IIRC). Doing a static link if you don't want the library dependency (and making it hermetic if you want it to be self-contained) SGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103960/new/

https://reviews.llvm.org/D103960