[libcxx-commits] [PATCH] D106704: [libc++] Implement the output_iterator and output_range concepts

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for working on this!
LGTM modulo some nits.



================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.output/output_iterator.compile.pass.cpp:46
+};
+static_assert(std::input_or_output_iterator<WrongPostIncrement>);
+static_assert(std::indirectly_writable<WrongPostIncrement, T>);
----------------
For consistency with the code above, please add a space after the opening parenthesis.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.output/output_iterator.compile.pass.cpp:57
+};
+static_assert(std::input_or_output_iterator<NotIndirectlyWritable>);
+static_assert(!std::indirectly_writable<NotIndirectlyWritable, T>);
----------------
For consistency with the code above, please add a space after the opening parenthesis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106704/new/

https://reviews.llvm.org/D106704