[libcxx-commits] [PATCH] D105791: [libcxx] adds `complexity_iterator`, `complexity_invocable`, and `test_algorithm`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I would suggest that you move `complexity_iterator` to the `ranges::find` patch so that it's added in the same patch that starts using it.



================
Comment at: libcxx/test/support/test_iterators.h:1055
+
+  [[nodiscard]] constexpr friend bool operator<(complexity_iterator const& x, complexity_iterator const& y)
+  requires std::random_access_iterator<I>
----------------
Remove `[[nodiscard]]`?


================
Comment at: libcxx/test/support/test_iterators.h:1084
+template<class I>
+complexity_iterator(I) -> complexity_iterator<I>;
+
----------------
This isn't needed, I think the default CTAD should work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105791/new/

https://reviews.llvm.org/D105791