[libcxx-commits] [PATCH] D106567: [libc++] [ranges] Replace __function_like inheritance with a macro.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I don't see anything wrong with this patch. However I'm not too fond of macro's so I prefer the approach taken in D105078 <https://reviews.llvm.org/D105078>.
I'm not fond of `export __function_like` in D105078 <https://reviews.llvm.org/D105078>. However I see that as work-around for a clang bug; once clang has been fixed it's possible to clean this up.

Actually the problem isn't the inheritance. My guess its usage causes the problem. For example D103357 <https://reviews.llvm.org/D103357> has the same issue. Here `std:optional<std::locale>` is a function argument. Even when the caller doesn't specify the argument (and thus uses the defaulted value for the argument) the issue occurs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106567/new/

https://reviews.llvm.org/D106567