[libcxx-commits] [PATCH] D105078: [libcxx][modularisation] properly modularises advance, next, and prev

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked 2 inline comments as done.
cjdb added a comment.

@ldionne now needs to weigh in on this in order for any progress to be made, which I was hoping to avoid.



================
Comment at: libcxx/include/module.modulemap:481
       module access                { private header "__iterator/access.h" }
-      module advance               { private header "__iterator/advance.h" }
+      module advance               {
+        private header "__iterator/advance.h"
----------------
Quuxplusone wrote:
> Mordante wrote:
> > cjdb wrote:
> > > Quuxplusone wrote:
> > > > zoecarver wrote:
> > > > > I don't like the formatting here. But whatever. 
> > > > There should be no need to `export __function_like` here. Then it'll all fit on one line, consistent with all the other lines, so there won't be a formatting problem anymore.
> > > > I don't like the formatting here. But whatever. 
> > > 
> > > Yeah, I didn't notice till after I threw it up on Phab. Will fix before merging.
> > > 
> > > > There should be no need to `export __function_like` here. Then it'll all fit on one line, consistent with all the other lines, so there won't be a formatting problem anymore.
> > > 
> > > There is a need to export `__function_like`. I've gone into this in other patches before, so I'm not going to repeat myself here.
> > > There should be no need to `export __function_like` here.
> > I agree, but clang disagrees. I had the same issue in my format series, before we made these headers private.
> > I know no other solution than what @cjdb did here.
> I've looked into it a bit, and uploaded D106567 with a simpler fix.
You have a strange definition of the word "simpler".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105078/new/

https://reviews.llvm.org/D105078