[libcxx-commits] [PATCH] D105078: [libcxx][modularisation] properly modularises advance, next, and prev

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision as: zoecarver.
zoecarver added a comment.

Thanks for the cleanup.



================
Comment at: libcxx/include/module.modulemap:481
       module access                { private header "__iterator/access.h" }
-      module advance               { private header "__iterator/advance.h" }
+      module advance               {
+        private header "__iterator/advance.h"
----------------
I don't like the formatting here. But whatever. 


================
Comment at: libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/special_function.compile.pass.cpp:17
-// XFAIL: clang-12 && modules-build
-// XFAIL: clang-13 && modules-build
-
----------------
Don't we still support clang-13 or am I missing something? Does this patch work around the bug? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105078/new/

https://reviews.llvm.org/D105078