[libcxx-commits] [PATCH] D102121: [libcxx][ranges] adds _`non-propagating-cache`_

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM!



================
Comment at: libcxx/test/libcxx/ranges/range.nonprop.cache/assign.copy.pass.cpp:50
+  {
+    Cache a; a.__set(T{3});
+    Cache b;
----------------
ldionne wrote:
> Mordante wrote:
> > This tests an implementation detail. Shouldn't this be guarded for usage with the libc++ library?
> > Other tests also use implementation details, please grep for `__`.
> This test lives in `libcxx/test/libcxx`, which is for implementation details only.
TIL. Seems I need to move some tests of my format series.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102121/new/

https://reviews.llvm.org/D102121