[libcxx-commits] [PATCH] D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8

[Nancy Wang via Phabricator via libcxx-commits]

NancyWang2222 added a comment.

In D106153#2891424 <https://reviews.llvm.org/D106153#2891424>, @ldionne wrote:

> In D106153#2890692 <https://reviews.llvm.org/D106153#2890692>, @ldionne wrote:
>
>> LGTM, but please add a 1-2 line comment for each `UNSUPPORTED` explaining why it fails. You can copy/paste the comment, it's fine. Actually, it even helps cause you can then grep for:
>>
>>   // <the-comment>
>>   // UNSUPPORTED: target={{.+}}-zos{{.*}}
>>
>> and you'll find all tests that are marked as unsupported for the same reason.
>
> @muiez
>
> Please read the comments even when you get an approval. https://reviews.llvm.org/rG7704fedfff6ef5676adb6415f3be0ac927d1a746 didn't apply my requested change. I LGTM'd the patch because I trusted you'd apply the feedback and didn't want to block you until I could look at it again -- not because no changes were required.

hi nothing to do w3ith Muiez, I asked his help to commit it for me. I didnt notice your comments.  I can add comment no problem


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106153/new/

https://reviews.llvm.org/D106153