[libcxx-commits] [PATCH] D103466: [libc++][format] Adds char formatter.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.functions/tests.inc:113
+  test_exception("A precision field isn't allowed in this format-spec",
+                 STR("{:.}"), CharT('*'));
+  test_exception("A precision field isn't allowed in this format-spec",
----------------
vitaut wrote:
> This should probably be fixed in a different diff but `.` alone is not a prevision field at all: http://eel.is/c++draft/format.string.std.
AFAICS this should give "The format-spec precision field doesn't contain a value or arg-id" according to the parsing logic in https://reviews.llvm.org/D103368.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103466/new/

https://reviews.llvm.org/D103466