[libcxx-commits] [PATCH] D103413: [libc++][format] Implement Unicode support.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added inline comments.


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:637-639
+/** Helper struct returned from @ref __get_format_string_traits. */
+template <class _CharT>
+struct _LIBCPP_TEMPLATE_VIS __format_string_traits {
----------------
vitaut wrote:
> nit: I would suggest changing the names of both `__format_string_traits` and `__get_format_string_traits` because the current naming gives an impressing that they have something to do with format strings while in fact this is an estimation of display width for a string argument. Maybe something along the lines of `__[format_]estimate_display_width` for the function name?
Or `__[format_]get_string_alignment` since it decides whether alignment should be applied and returns information about how to apply it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103413/new/

https://reviews.llvm.org/D103413