[libcxx-commits] [PATCH] D105905: [libcxx] [test] Fix experimental/memory.resource.adaptor.mem/db_deallocate on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D105905#2883789 <https://reviews.llvm.org/D105905#2883789>, @ldionne wrote:

> In D105905#2880877 <https://reviews.llvm.org/D105905#2880877>, @mstorsjo wrote:
>
>> @ldionne - What’s your opinion on this one?
>
> `std::pmr::memory_resource` is clearly spec'd to use `std::max_align_t`, so I agree this is the intended behavior (http://eel.is/c++draft/mem.res#class.general-1).

Thanks!

> I audited D73245 <https://reviews.llvm.org/D73245>, and the following changes don't look right to me in retrospect:
>
>   libcxx/test/std/containers/sequences/array/size_and_alignment.pass.cpp (I don't see what __STDCPP_DEFAULT_NEW_ALIGNMENT__ has to do with the alignment in std::array)
>   libcxx/test/std/language.support/support.types/max_align_t.pass.cpp (I think we should remove `#ifdef __STDCPP_DEFAULT_NEW_ALIGNMENT__`)
>
> What do you both think?

Can someone else than me pick up moving forward with those - separately from this patch? I presume this particular patch could be OK'd then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105905/new/

https://reviews.llvm.org/D105905