[libcxx-commits] [PATCH] D106124: [libcxx][modules] protects users from relying on ranges detail headers
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jul 16 11:05:53 PDT 2021
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Could this be implemented as a pragma? We have `#pragma GCC system_header`, perhaps we could have `#pragma clang include_instead("<ranges>")` or something along those lines? That would also be more generally useful outside of the standard library.
As it is, I find the benefit provided doesn't clearly surpass the amount of boilerplate needed to make it work. Also, if we want to make this worthwhile in any form, we'll have to automate the creation of those tests (or do that on the fly with a `.sh.cpp` test like Zoe suggests). We don't want to add a manual step like this every time we add a detail header -- we have many of those.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106124/new/
https://reviews.llvm.org/D106124
More information about the libcxx-commits
mailing list