[libcxx-commits] [PATCH] D106092: [libcxx] Updated test and seemingly incorrect comment from it.

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 15 23:09:39 PDT 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_destruction_order.pass.cpp:60
+  // On Microsoft ABI, the dtor order is always A,B,C (because callee-destroyed)
+  assert(shared_buf[0] == 'A' && shared[1] == 'B' && shared_buf[1] == 'C');
+#else
----------------
There's two trivial typos here, the second one is `shared[1]` when it should be `shared_buf[1]`, and the third index should be `[2]`, not `[1]` again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106092/new/

https://reviews.llvm.org/D106092



More information about the libcxx-commits mailing list