[libcxx-commits] [PATCH] D106107: [libc++][NFC] Split <compare> into internal headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb requested changes to this revision.
cjdb added a comment.
This revision now requires changes to proceed.

This should be mostly ready to go (I'm a bit surprised we only need two headers). Two bits of feedback.

1. **Blocking:** Please add these to the module map. The `ranges.__ranges` submodule should give you guidance on how to make the `compare.__compare` submodule. I'll LGTM once this is done.
2. Non-blocking: I'd appreciate it if you could change `[NFC]` in your commit summary to `[modularisation]`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106107/new/

https://reviews.llvm.org/D106107