[libcxx-commits] [PATCH] D104315: [libc++] Promote GCC 11 to mandatory CI

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_is_lock_free.pass.cpp:30
     typedef std::atomic<T> A;
-    A t;
+    A t = T();
     bool b1 = std::atomic_is_lock_free(static_cast<const A*>(&t));
----------------
mizvekov wrote:
> This initialization and the similar one below would not work from C++14 and below.
> std::atomic is not copy construtible, and only starting from C++17 this initialization here from a prvalue of the same type performs direct initialization, and not a copy.
Just circling back -- we solved this in our discussion on Discord, and I'm fixing it in D105936.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104315/new/

https://reviews.llvm.org/D104315