[libcxx-commits] [PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment

[H.J Lu via Phabricator via libcxx-commits]

hjl.tools added inline comments.


================
Comment at: libunwind/src/cet_unwind.h:28
+      else {                                                                   \
+        unsigned int iters = (x) / 255;                                        \
+        unsigned int rem = (x) % 255;                                          \
----------------
xiongji90 wrote:
> hjl.tools wrote:
> > Why are / and % used here?  You pop 255 frames a time if numbers of frame > 255.
> Removed unnecessary % and /.
Can you do


```
while (tmp > 255)
{
...
}
```

and remove if/else?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105968/new/

https://reviews.llvm.org/D105968