[libcxx-commits] [PATCH] D105932: [libcxx][modules] protects users from relying on libc++ detail headers (1/n)

[Stephan T. Lavavej via Phabricator via libcxx-commits]

STL_MSFT added inline comments.


================
Comment at: libcxx/utils/generate_private_header_tests.py:19
+
+// REQUIRES: modules-build
+
----------------
cjdb wrote:
> miscco wrote:
> > Just to be sure, can we disable this for MSVC STL? There are no such headers there and this is rather specific to libc++
> These test are generated in libcxx/test/libcxx, which tests libc++ internals, so I don't think it's necessary to guard on that. Having said that, shouldn't `REQUIRES: modules-build` disable for Microsoft/STL anyway?
microsoft/STL runs only `libcxx/test/std`, not `libcxx/test/libcxx`, so this sounds perfectly fine to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105932/new/

https://reviews.llvm.org/D105932