[libcxx-commits] [PATCH] D105932: [libcxx][modules] protects users from relying on libc++ detail headers (1/5)

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb updated this revision to Diff 358650.
cjdb retitled this revision from "[libcxx][modules] protects users from relying on libc++ detail headers (1/4)" to "[libcxx][modules] protects users from relying on libc++ detail headers (1/5)".
cjdb edited the summary of this revision.
cjdb removed a project: libc++abi.
cjdb added a comment.

- completely rolls back libcxxabi changes
- makes `<__threading_support>` a "public" header again
- expands number of commits this will take from 4 to 5 to account for `<__threading_support>`.

I don't see why libcxxabi couldn't instead include `<thread>` to get what's needed out of `<__threading_support>`, but I'm not convinced that's the right path forward without giving it some thought. Probably best to defer that to another patch where it owns the spotlight.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105932/new/

https://reviews.llvm.org/D105932

Files:
  libcxx/include/module.modulemap
  libcxx/include/span
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/assign.copy.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/assign.move.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/ctor.default.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/ctor.in_place.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/deref.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/has_value.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/no_unique_address.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/properties.compile.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h
  libcxx/test/std/containers/views/span.sub/first.fail.cpp
  libcxx/test/std/containers/views/span.sub/last.fail.cpp
  libcxx/test/std/containers/views/span.sub/subspan.fail.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_adopt_lock.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_defer_lock.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock_for.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/try_lock_until.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/unlock.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/op_bool.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/types.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105932.358650.patch
Type: text/x-patch
Size: 45611 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210714/cdbfb596/attachment-0001.bin>