[libcxx-commits] [PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added inline comments.


================
Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22
+The instructions on this page are aimed at vendors who ship Compiler-RT as part of an
+operating system distribution, a toolchain or similar shipping vehicules. If you
+are a user merely trying to use Compiler-RT in your program, you most likely want to
+refer to your vendor's documentation, or to the general documentation for using
+Compiler-RT :ref:`here <using-libcxx>`.
+
+.. warning::
----------------
phosek wrote:
> Ericson2314 wrote:
> > Modeled this file off libc++'s, including taking these two paragraphs. They seem appropriate enough here.
> I'm not sure how appropriate this is actually since Compiler-RT is usually shipped together with the compiler, not the operating system (unlike libc++) since the LLVM and Compiler-RT ABI is tightly coupled. I'd omit this for now.
Fair enough. Removed.


================
Comment at: compiler-rt/docs/BuildingCompilerRT.rst:16
+refer to your vendor's documentation, or to the general documentation for using
+Compiler-RT :ref:`here <using-libcxx>`.
+
----------------
phosek wrote:
> compiler-rt?
Ah there is no such section for `compiler-rt/docs`. I deleted and reworded.


================
Comment at: compiler-rt/docs/BuildingCompilerRT.rst:59
+  ``-DCOMPILER_RT_INSTALL_PATH:PATH=...`` not
+  ``-DCOMPILER_RT_INSTALL_PATH:PATH=...``, otherwise CMake will convert the
+  path to an absolute path.
----------------
phosek wrote:
> Is this what you meant here?
Oops. Yes.


================
Comment at: compiler-rt/docs/BuildingCompilerRT.rst:87
+
+  Path where Compiler-RT headers should be installed. If a relative
+  path, relative to ``COMPILER_RT_INSTALL_PATH``.
----------------
phosek wrote:
> This variable is used for data files (like resources), not headers.
Says "data" like the CMake variale description does now too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105765/new/

https://reviews.llvm.org/D105765