[libcxx-commits] [PATCH] D103335: [libcxx][ranges] Adds `common_iterator`.

[Tim Song via Phabricator via libcxx-commits]

tcanens added inline comments.


================
Comment at: libcxx/include/__iterator/common_iterator.h:54
+    constexpr __postfix_proxy(iter_reference_t<_Iter>&& __x)
+      : __value(__x) {}
+
----------------
zoecarver wrote:
> tcanens wrote:
> > Missing forward here.
> Why not move this one too?
They are really both `forward`s; the difference is that `operator->`'s proxy only gets used when `iter_reference_t<I>` isn't a reference, so that forward ends up being a move.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103335/new/

https://reviews.llvm.org/D103335