[libcxx-commits] [PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 marked an inline comment as done.
Ericson2314 added inline comments.


================
Comment at: compiler-rt/cmake/base-config-ix.cmake:97
+  else()
+    set(temp_path "${temp_path}/${current_segment}")
+  endif()
----------------
phosek wrote:
> This isn't set before so it should be always empty in which case you'll end up with an absolute path (that is `/${current_segment}`) right? Isn't that a bug?
Eek! that's embarrassing. Turns out that testing with `-D` is more fraught than I thought, and I wasn't hitting that case. Fixed the bug and documented the `-D` subtlety too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105765/new/

https://reviews.llvm.org/D105765