[libcxx-commits] [PATCH] D103413: [libc++][format] Implement Unicode support.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added inline comments.


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:660-662
+   * number of columns in the output. So if the formatted output has only a
+   * minimum width the exact size isn't important. It's only important to know
+   * the minimum has been reached.
----------------
I am not sure I understand what "the formatted output has only a minimum width" means. What is the minimum width?


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:668
+   * * @ref __align == @c false the @ref __size is the estimated number of
+   *   columns required or 0 when the estimation algorithm stopped prematurely.
+   */
----------------
Why would the estimation algorithm stop prematurely?


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:687
+ *
+ * Unicode can be stored in several formats UTF-8, UTF-16, and UTF-32.
+ * Depending on format the relation between the number of code units stored and
----------------
nit: I'd add a colon after "formats".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103413/new/

https://reviews.llvm.org/D103413