[libcxx-commits] [PATCH] D104987: Use GetSystemTimePreciseAsFileTime() if available

Saleem Abdulrasool via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 9 10:34:01 PDT 2021


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

Could you please improve the commit message to explain the reasoning for this?  `GetSystemTimePreciseAsFileTime` has been available since Windows 8+, which has already been EOL'ed.  Windows 10 is supposed to be EOL'ed in ~4 years.  So, being more explicit about the reasoning for the dynamic resolution of the function in the commit message seems reasonable.

I think that the changes that @amccarth suggested are the right way to handle this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104987/new/

https://reviews.llvm.org/D104987



More information about the libcxx-commits mailing list