[libcxx-commits] [PATCH] D105597: [libcxx][nfc] Remove <variant>'s dependence on <array>.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/variant:515
                                size_t __index, _Indices... __indices) {
     return __at(__elems[__index], __indices...);
   }
----------------
It occurs to me that you could eliminate `__farray::operator[]`, and just use `__elems.__buf_[__index]` right here, and on line 490 use `__fdiagonal.__buf_[__index]` instead of `__fdiagonal[__index]`. Then `__farray` would be a two-liner, and I think that'd be nice.
This isn't a blocker, but I'd like to see it done in a followup commit unless @ldionne thinks it would //not// be a good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105597/new/

https://reviews.llvm.org/D105597