[libcxx-commits] [PATCH] D105456: [libcxx][algorithms] adds `std::ranges::find`

Tim Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 8 09:51:21 PDT 2021


tcanens added inline comments.


================
Comment at: libcxx/include/__functional/identity.h:34
+
+using identity = __identity_fn;
+
----------------
cjdb wrote:
> tcanens wrote:
> > This is nonconforming.
> Why?
`struct std::identity` is required to work and doesn't if it is a _typedef-name_.

Also, the injected-class-name is different and as a public member that is observable.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105456/new/

https://reviews.llvm.org/D105456



More information about the libcxx-commits mailing list