[libcxx-commits] [PATCH] D105563: [libc++][docs] Update documentation to reflect libc++'s compiler support policy

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 7 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/docs/index.rst:113
+=============== ==================== ============================
+Target platform Target architecture  Notes
+=============== ==================== ============================
----------------
mstorsjo wrote:
> phosek wrote:
> > I'd be interested in including Fuchsia here but we don't have bots yet, it's something we plan to work on in H2 2021.
> Windows is missing in this list. In practice it works for i386, x86_64, ARM and ARM64, but the CI setup covers x86_64. In my downstream usage it practically runs fine on all of them (but I haven't run full testsuite rounds on other than x86_64 and arm64).
@phosek Awesome, I'll be looking forward to helping you setup Fuchsia build bots and then adding it to the list.

@mstorsjo I'll add Windows to the list. I based this off of the list we had previously, but I guess it makes sense to complete it. Are there any plans to add real CI for Windows / `arm64`?


================
Comment at: libcxx/docs/index.rst:115
+=============== ==================== ============================
+macOS 10.9+     i386, x86_64, ARM    Building the shared library itself requires targetting macOS 10.12+
+FreeBSD 10+     i386, x86_64, ARM
----------------
rnk wrote:
> phosek wrote:
> > Since we're distinguishing 32-bit and 64-bit x86, shall we also do the same for ARM, that is have ARM and ARM64?
> I think Chrome still builds libc++ statically for 10.11:
> https://source.chromium.org/chromium/chromium/src/+/main:build/config/mac/mac_sdk.gni;l=21
> 
> Some time in the next year or two it will likely be raised, but I can't commit to a timeline. If someone lands changes that don't work on 10.11, someone from our team will try to put together a workaround patch for 10.11. The audience for this document is probably libc++ developers, so if they want to minimize the amount of post-commit code review work, it might be less work to use 10.11 here.
Oh yeah, you're right. Adjusting.


================
Comment at: libcxx/docs/index.rst:116
+macOS 10.9+     i386, x86_64, ARM    Building the shared library itself requires targetting macOS 10.12+
+FreeBSD 10+     i386, x86_64, ARM
+Linux           i386, x86_64
----------------
emaste wrote:
> ldionne wrote:
> > @dim Would it be possible to set up a FreeBSD bot? I'm happy to help you with that, but we need one if we don't want to be lying here.
> I'll take this on.
Awesome, thanks. What we're looking for is a BuildKite bot, as documented here: https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs.

Feel free to ping me on Discord and I'll help you set them up, it's pretty easy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105563/new/

https://reviews.llvm.org/D105563