[libcxx-commits] [PATCH] D104980: [libcxx][NFC] replaces `<utility>` includes with specific headers

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 7 11:43:45 PDT 2021


cjdb added a comment.

In D104980#2862532 <https://reviews.llvm.org/D104980#2862532>, @EricWF wrote:

> So we're splitting up the headers (which I don't love, but will hold my tongue for the most part).
>
> The intention is to provide better name hygene for our users. Meaning headers will export _fewer_ names than they do at present.
> This is an intentional BREAKING change. Users will have to update their code to include the correct headers before it will compile.
>
> Before we do this we need to:
>
> 1. Announce and discuss this change, it's rational, and its benefits to *all libc++ vendors*.
> 2. Document the list of names removed from every header. This list should be complete.
> 3. Ensure Clang's error messages tell users _which_ headers to include. Or at least don't tell users to include the wrong (implementation) headers.

Agreed. Specifically responding to (3): D105439 <https://reviews.llvm.org/D105439> is the first of a few patches that I'm working on to get Clang to minimise the pain from breakages and prevent users from making certain mistakes in the interim.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104980/new/

https://reviews.llvm.org/D104980



More information about the libcxx-commits mailing list