[libcxx-commits] [PATCH] D103335: [libcxx][ranges] Adds `common_iterator`.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver updated this revision to Diff 356841.
zoecarver marked an inline comment as done.
zoecarver added a comment.

- I think I adressed all the review comments that apply from the other two views. (If not, sorry, let me know and I'll fix them here too.)
- I'm going to update common_iterator to use variant. Because it's not yet constexpr, I'm just going to comment out the static_assert in all the tests. This makes us support closer to the standard anyway. Note: I have not done this yet because it requries fixing a dependency cycle between iterator -> array -> variant -> iterator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103335/new/

https://reviews.llvm.org/D103335

Files:
  libcxx/docs/OneRangesProposalStatus.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__iterator/common_iterator.h
  libcxx/include/iterator
  libcxx/test/std/iterators/predef.iterators/iterators.common/arrow.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/assign.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/ctor.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/deref.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/eq.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/iter_move.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/iter_swap.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/iterator_traits.compile.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/members.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/minus.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/plus_plus.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/types.h
  libcxx/test/support/test_iterators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103335.356841.patch
Type: text/x-patch
Size: 58181 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210707/b09d0120/attachment-0001.bin>