[libcxx-commits] [PATCH] D102135: [libcxx][ranges] adds _`copyable-box`_
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jul 6 12:51:01 PDT 2021
Mordante accepted this revision.
Mordante added a comment.
LGTM, one minor question.
================
Comment at: libcxx/include/__ranges/copyable_box.h:118
+ class __copyable_box<_Tp> {
+ [[no_unique_address]] _Tp __val_;
+
----------------
Is there a reason to use `[[no_unique_address]]` here? Don't the same justifications hold true as stated in the primary template?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102135/new/
https://reviews.llvm.org/D102135
More information about the libcxx-commits
mailing list