[libcxx-commits] [PATCH] D105499: [libc++] Do not set CMAKE_BUILD_WITH_INSTALL_NAME_DIR

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: arichardson, mgorny.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

I'm not sure what that gains us, and it creates a problem when
trying to run the tests against libc++ with a custom install name
dir (e.g. /usr/lib), since the library that we link against (in
the build tree) will advertise itself as /usr/lib/libc++.dylib,
so we end up linking against the system dylib at runtime.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105499

Files:
  libcxx/CMakeLists.txt
  libcxx/utils/ci/runtimes/CMakeLists.txt


Index: libcxx/utils/ci/runtimes/CMakeLists.txt
===================================================================
--- libcxx/utils/ci/runtimes/CMakeLists.txt
+++ libcxx/utils/ci/runtimes/CMakeLists.txt
@@ -1,8 +1,6 @@
 cmake_minimum_required(VERSION 3.13.4)
 project(LLVM_RUNTIMES C CXX ASM)
 
-set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)
-
 find_package(Python3 COMPONENTS Interpreter)
 if(NOT Python3_Interpreter_FOUND)
   message(WARNING "Python3 not found, using python2 as a fallback")
Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -10,8 +10,6 @@
 #===============================================================================
 cmake_minimum_required(VERSION 3.13.4)
 
-set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)
-
 # Add path for custom modules
 set(CMAKE_MODULE_PATH
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105499.356767.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210706/bfc521bf/attachment.bin>