[libcxx-commits] [PATCH] D97870: [libc++] Add missing header <cuchar>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 6 06:59:35 PDT 2021


Quuxplusone added a comment.

> I did something that we usually don't do here - I made the <cuchar> and <uchar.h> headers fail with an explicit error when included in C++03 mode. The rationale for doing that is that the headers won't work in C++03 mode (they require the char16_t type, which is in C++11)

In the spirit of my "remove `_LIBCPP_CXX03_LANG`" patch series: We care about compiling in C++03 mode only with Clang, right? So how about doing some macro magic in `<__config>` that makes our `char16_t` an alias for Clang's uglified built-in `__char16_t` on-Clang-in-C++03-mode? And then on every other compiler we just use `char16_t` directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97870/new/

https://reviews.llvm.org/D97870



More information about the libcxx-commits mailing list