[libcxx-commits] [PATCH] D104980: [libcxx][NFC] replaces `<utility>` includes with specific headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked an inline comment as done.
cjdb added inline comments.


================
Comment at: libcxx/include/__functional/greater.h:52-55
+    _NOEXCEPT_(noexcept(static_cast<_T1&&>(__t) > static_cast<_T2&&>(__u)))
+    -> decltype        (static_cast<_T1&&>(__t) > static_cast<_T2&&>(__u))
+        { return        static_cast<_T1&&>(__t) > static_cast<_T2&&>(__u); }
     typedef void is_transparent;
----------------
Mordante wrote:
> cjdb wrote:
> > ldionne wrote:
> > > What's the rationale for making this change here? Why not include `__utility/forward.h`?
> > Oh, did this slip through? I was experimenting with something and then abandoned it. Will fix.
> I noticed the same change at other places too.
It's moot because these files don't exist any more.


================
Comment at: libcxx/include/mutex:200
 #endif
+#include <type_traits> // __invoke
 #include <version>
----------------
Mordante wrote:
> D104942 landed `__functional/invoke.h`, can you use that? If not please update the comment.
Out of scope: I'll apply it in D104982.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104980/new/

https://reviews.llvm.org/D104980