[libcxx-commits] [PATCH] D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Is there any way you folks could try to use configuration files like `libcxx/test/configs/libcxx-trunk-shared.cfg.in` instead of augmenting the old `config.py`? I'm trying to move all of the testing infrastructure over to those, since they are a lot more flexible and straightforward to define. Right now there's a bit of boilerplate in those config files, but the gist of it is that you define exactly how the compiler is to be called on the test files:

  config.substitutions.append(('%{cxx}', COMPILER))
  config.substitutions.append(('%{flags}',
      '-isysroot {}'.format(CMAKE_OSX_SYSROOT) if CMAKE_OSX_SYSROOT else ''
  ))
  config.substitutions.append(('%{compile_flags}',
      '-nostdinc++ -isystem {} -I {}'.format(
          os.path.join(INSTALL_ROOT, 'include', 'c++', 'v1'),
          os.path.join(LIBCXX_ROOT, 'test', 'support'))
  ))
  config.substitutions.append(('%{link_flags}',
      '-nostdlib++ -L {0} -lc++ -Wl,-rpath,{0} -pthread'.format(
          os.path.join(INSTALL_ROOT, 'lib'))
  ))
  config.substitutions.append(('%{exec}',
      '{} {} --execdir %T -- '.format(
          pipes.quote(sys.executable),
          pipes.quote(runPy))
  ))

You can see how to select your testing configuration here: https://libcxx.llvm.org/TestingLibcxx.html#using-a-custom-site-configuration


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102632/new/

https://reviews.llvm.org/D102632