[libcxx-commits] [PATCH] D105296: [libcxx] Update optional star operator to be noexcept.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

LGTM % comment, but it's major.



================
Comment at: libcxx/test/std/utilities/optional/optional.object/optional.object.observe/dereference_const.pass.cpp:40
         ASSERT_SAME_TYPE(decltype(*opt), X const&);
+        LIBCPP_STATIC_ASSERT(noexcept(*opt));
         // ASSERT_NOT_NOEXCEPT(*opt);
----------------
Should use `ASSERT_NOEXCEPT(*opt);`
However, is this guaranteed by the Standard? or should this actually be a new test file in libcxx/test/libcxx/ because it's a conforming extension we're doing?
If new file, then I think one file (not four) would suffice: `dereference_noexcept.compile.pass.cpp` or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105296/new/

https://reviews.llvm.org/D105296