[libcxx-commits] [PATCH] D104942: [libcxx][functional][modular] splices <functional> into modular headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne commandeered this revision.
ldionne edited reviewers, added: cjdb; removed: ldionne.
ldionne added a comment.

Commandeering to fix the few last issues and get a CI build going before Chris is up!



================
Comment at: libcxx/include/CMakeLists.txt:124-129
+  __functional/ranges/equal_to.h
+  __functional/ranges/greater_equal.h
+  __functional/ranges/greater.h
+  __functional/ranges/less_equal.h
+  __functional/ranges/less.h
+  __functional/ranges/not_equal_to.h
----------------
The same reasoning that we discussed applies for these operations - let's group them.

Also, let's try to avoid 3 levels of nesting if we can.


================
Comment at: libcxx/include/__functional/bind.h:13-18
+#include <__config>
+#include <__functional/weak_result_type.h>
+#include <__functional/invoke.h>
+#include <cstddef>
+#include <tuple>
+#include <type_traits>
----------------
Please take the habit of sorting includes.


================
Comment at: libcxx/include/__functional_base:16
+#include <__functional/invoke.h>
+#include <__functional/less.h>
+#include <__functional/reference_wrapper.h>
----------------
Oops, those haven't been updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104942/new/

https://reviews.llvm.org/D104942