[libcxx-commits] [PATCH] D91170: [15/N] [libcxx] Implement the canonical function for windows
Adrian McCarthy via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jan 29 10:45:09 PST 2021
amccarth accepted this revision.
amccarth added a comment.
The changes to provide `realpath` on Windows looks right. Since it's relying on a system call, it would be difficult to create tests for the `\\?\` and UNC cases. I'm assuming the more mainstream cases will be tested by existing tests. So LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91170/new/
https://reviews.llvm.org/D91170
More information about the libcxx-commits
mailing list