[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 29 03:55:42 PST 2021


Mordante added a comment.

I agree it would be nice to allow C++17 and C++20 for a limited time. It would be a bit of a maintenance burden, but I feel it benefits our users. I think we can state users are allowed to use C++17, but it's not officially supported. We could make a Cmake switch to opt-in to this behavior, but I feel that would be overkill.

I think once C++20 becomes mandatory we should remove the `#if _LIBCPP_STD_VER > 17` from the files in `src`. Then the extra burden is only there for a limited time.

I'll make a patch to remove the 2 occurrences of `#if _LIBCPP_STD_VER > 11` from `src`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214



More information about the libcxx-commits mailing list