[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D92214#2528690 <https://reviews.llvm.org/D92214#2528690>, @thakis wrote:

> Hello, this again breaks building with -std=c++17: the cpp file has the definition but not the declaration in that case. Should libc++ sources be built with -std=c++20? Or should the cpp file also check `_LIBCPP_STD_VER`?

I had this in my original version, but I removed it after review this review comment
https://reviews.llvm.org/D92214#inline-887948

> To answer my question: Yes, C++20 should be used, see 3b625060fc915 <https://reviews.llvm.org/rG3b625060fc91598d28196e559196bfc7b9a929f9>.

That doesn't really answer the question since that made C++20 preferred but not mandatory. That was the intention.

@ldionne Can you clarify the status of libc++'s C++20 requirements. If optional should I re-add the version check macro's in the .cpp file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214