[libcxx-commits] [PATCH] D93461: [libc++] Implements concept default_initializable.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

This LGTM except for the nitpick.



================
Comment at: libcxx/test/std/concepts/concept.default.init/default_initializable.verify.cpp:33
+    static_assert( brace_initializable<S0>);
+    static_assert( std::__default_initializable<S0>);
+    static_assert( std::default_initializable<S0>);
----------------
These implementation details of libc++ shouldn't be tested here, or if they are, then we should use `LIBCPP_STATIC_ASSERT` (which expands to nothing when testing a non-libc++ library).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93461/new/

https://reviews.llvm.org/D93461