[libcxx-commits] [PATCH] D93557: [libc++] [P0879] constexpr std::nth_element, and rewrite its tests.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 319640.
Quuxplusone added a comment.

Add "simple" tests per @ldionne's preferences. :)
I looked at ways to remove that `continue;` and realized that the thing I was thinking of wouldn't work. (The section I was saying I could put in an `else` block, would actually have to go in a separate helper function so that it could be reached along two different codepaths.) So I'd say let's ship this as-is, and let someone else refactor it if they want to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93557/new/

https://reviews.llvm.org/D93557

Files:
  libcxx/include/algorithm
  libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element.pass.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.nth.element/nth_element_comp.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93557.319640.patch
Type: text/x-patch
Size: 16061 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210127/fe2cfef8/attachment.bin>