[libcxx-commits] [PATCH] D94807: [libc++] Rationalize our treatment of contiguous iterators and __unwrap_iter().

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 27 10:44:43 PST 2021

ldionne added a comment.

In D94807#2520593 <https://reviews.llvm.org/D94807#2520593>, @rnk wrote:

> In the discussion on the bug with the author of these checked iterators, they seemed OK with relying on implementation details, including re-opening the `std::__1` namespaces with the necessary macros to make the `__unwrap_iter` overload work. I think the optimization only has to work with bundled libc++ version. If that is not in use, the optimization is disabled. I think we might be OK without a properly supported way to do this until we make it to C++20. NaCl is supposed to go away in 2021, so at that point we could probably spring forward and use the officially supported mechanism.

Okay, so if I'm reading this correctly, we basically don't have anything to do as requested on D92776 <https://reviews.llvm.org/D92776>.

Arthur, some of this stuff landed in C++20, so we can still do it, but in C++20 only. Are you OK with that?

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list