[libcxx-commits] [PATCH] D93414: [libc++] Adds a make_string test helper function.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added subscribers: mstorsjo, curdeius.
curdeius accepted this revision.
curdeius added a comment.

LGTM. Just 2 nits.
Have you looked at what @mstorsjo did in his series of patches for porting filesystem to Windows? I have a vague idea that there were some converting utilities similar to this one.



================
Comment at: libcxx/test/support/make_string.h:23
+// Some of these std::codecvt specializations have been deprecated. At the
+// moment are no replacements in the Standard so use the deprecated facilities.
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
----------------
Nit: "there are no" instead of "are no".


================
Comment at: libcxx/test/support/make_string.h:30
+std::basic_string<CharT> make_string(const char* str) {
+  struct convertor_type : public std::codecvt<CharT, char, std::mbstate_t> {
+    using std::codecvt<CharT, char, std::mbstate_t>::codecvt;
----------------
Nit: convertor? Why not converter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93414/new/

https://reviews.llvm.org/D93414