[libcxx-commits] [PATCH] D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit

Arutyunyan, Ruslan via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 25 12:40:24 PST 2021


Yes, CI didn't start for some reason.

Sorry for build break, I tried to fix it as soon as possible.

Anyway thanks a lot for your help, guys.

Best Regards,
Ruslan

-----Original Message-----
From: Louis Dionne via Phabricator <reviews at reviews.llvm.org> 
Sent: 25 января 2021 г. 23:16
To: Arutyunyan, Ruslan <ruslan.arutyunyan at intel.com>; z.zoelec2 at gmail.com; mcypark at gmail.com; eric at efcs.ca; mclow.lists at gmail.com; minjaehwang at google.com; curdeius at gmail.com; mikhail.maltsev at arm.com; dsantosp12 at gmail.com; mschellenbergercosta at gmail.com; fady.farag at smail.astate.edu
Cc: libcxx-commits at lists.llvm.org
Subject: [PATCH] D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit

ldionne added a comment.

Thanks a lot Nico. The back story is that CI didn't run for that revision due to a misconfigured repository on the Phab revision. This is a great reminder that we should never skip pre-commit CI for non-trivial changes. This is my fault, I should have requested that the author updates the patch with a proper repository set so CI would trigger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92044/new/

https://reviews.llvm.org/D92044


--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the libcxx-commits mailing list