[libcxx-commits] [PATCH] D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit
Nico Weber via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jan 25 12:11:35 PST 2021
thakis added inline comments.
================
Comment at: libcxx/include/variant:657
};
+#endif
----------------
thakis wrote:
> Should this endif be a line further up? This comments out the end of the class. My `-std=c++17` bot is red because of this: http://45.33.8.238/linux/37893/step_4.txt
>
> (Is c++20 required to build libc++ now?)
I went ahead and pushed a fix for this at a206d991f96ba5c864aa6527f87b72ab1fdf3f4c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92044/new/
https://reviews.llvm.org/D92044
More information about the libcxx-commits
mailing list