[libcxx-commits] [PATCH] D93512: [libc++] [P0879] constexpr heap and partial_sort algorithms
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jan 25 09:08:52 PST 2021
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Generally looks good, I'm just asking for a bit more manual testing. Thanks a lot for working on this, I love that we're removing dependencies on `<random>`.
================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.heap.operations/make.heap/make_heap.pass.cpp:26
{
- int* ia = new int [N];
- for (int i = 0; i < N; ++i)
- ia[i] = i;
- std::shuffle(ia, ia+N, randomness);
- std::make_heap(ia, ia+N);
- assert(std::is_heap(ia, ia+N));
-
- typedef random_access_iterator<int *> RI;
- std::shuffle(RI(ia), RI(ia+N), randomness);
- std::make_heap(RI(ia), RI(ia+N));
- assert(std::is_heap(RI(ia), RI(ia+N)));
-
- delete [] ia;
+ int orig[15] = {3,1,4,1,5, 9,2,6,5,3, 5,8,9,7,9};
+ T work[15] = {3,1,4,1,5, 9,2,6,5,3, 5,8,9,7,9};
----------------
Can you please also add a few dumb hand-written test cases? You know I love those, right?
Same for the other algorithms whose tests have been rewritten.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93512/new/
https://reviews.llvm.org/D93512
More information about the libcxx-commits
mailing list