[libcxx-commits] [PATCH] D91986: [libc++] Implements concept constructible_from

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review.



================
Comment at: libcxx/test/std/concepts/concept.constructible/constructible_from.compile.pass.cpp:41-45
+// Since C++17 dynamic exception specifications are no longer
+// part of the standard.
+struct Throw {
+  ~Throw() throw();
+};
----------------
cjdb wrote:
> Post-LGTM nit: do we really need this one if it's no longer standard?
What I mentioned was that `~Throw() throw(int);` is no longer supported. However just saw this version is no longer deprecated but has been removed in C++20 http://eel.is/c++draft/diff.cpp17.except.

I'll update the patch. I also used this test in D91004, which I just committed. I'll commit a patch to also remove it in that test.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91986/new/

https://reviews.llvm.org/D91986