[libcxx-commits] [PATCH] D62641: Support arrays in make_shared and allocate_shared (P0674R1)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/create_array.pass.cpp:9
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
----------------
zoecarver wrote:
> zoecarver wrote:
> > ldionne wrote:
> > > I would like to see more tests for:
> > > 
> > > 1. Multidimensional construction and destruction, and
> > > 2. Making sure that we construct and destroy elements in the correct order (both in normal circumstances but also when an exception is thrown while we're initializing the array).
> > > 
> > > I know this is complicated to test, but I think it is important. It may make sense to split tests into multiple files to make it easier to understand. Your call.
> > Improved this a little, but I'm going to upload more tests shortly. 
> Oops, forgot the SFINAE test. I'll add that now. 
> I know this is complicated to test, but I think it is important. It may make sense to split tests into multiple files to make it easier to understand. Your call.

I personally don't mind the mono-test and it makes things easier to find, IMHO. But I also don't have a strong oppinion at all, would you rather me split this test up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62641/new/

https://reviews.llvm.org/D62641