[libcxx-commits] [PATCH] D92229: [libc++] Update clang-format configuration

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 19 10:45:09 PST 2021


ldionne added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:18
 steps:
+  - label: "Format"
+    command: "libcxx/utils/ci/run-buildbot check-format"
----------------
To unblock this and get started even without having entirely settled all formatting questions, I suggest we make this step a soft-fail:

```
soft_fail:
      - exit_status: 1
```

(described at https://buildkite.com/docs/pipelines/command-step#soft-fail-attributes)

Then, we'll be able to play around a bit with the configuration. Once we've settled on something, we can remove the soft-fail on the step to enforce formatting for new commits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92229/new/

https://reviews.llvm.org/D92229



More information about the libcxx-commits mailing list